All of these are top notch teachers, but I have to add Jeff McBride to the list.
Keith Shazam

I am glad someone besides me, agrees Dr. Michael Rubinstein's teaching ability with coins is supurb! The Encylopedia Of Coins Sleights, specifically. Also, Knockout Coin Magic!

Doug

Doug he also has some of the best dry jokes around, well at least I like them.

Dr. Rubinstein was a lecturer at our SAM meeting.
I bought one of his DVD's. I agree, he is an excellent teacher.

Kbuck54...you are spot on. I'm not a fan of Jeff's style of magic, but have always admired his skill, experience, and knowledge of the magic arts. It's a cliche statement, but he's forgotten more about magic than I'll ever know.

That aside, it wasn't until I began reading articles by him that I really came to appreciate his teaching skills. Magic experience and knowledge is one thing, but Jeff is so eloquent in his explanations, and positive in his teachings, that one is immediately drawn into the learning process. He seems to truly be a magic Sensei.

Wiz,
You hit the nail on the head. Jeff is the one that gave me the Shazam, at one of his classes. What's the old joke that Michael Ammar tells about Jeff's latest DVD / It's called " All the Tricks I do Better Than You."
No really. I love that guy.
Keith Shazam

I agree with all that are stated so far. Along with Jay Sankey I have to include Gregory Wilson how likes to add comedy while teaching and keeps the teaching fun.

Also I have to say the great Tommy Wonder was brilliant teacher of the why and of the outside the box thinkers

I think one of the best teachers that was on here was Mark Lewis.

I forgot to mention Christopher T. Magician with his web episodes and Dvd Live From the Living Room. He doesn't just go into detail he gives you new ideas and little tidbits that you can run with. Reminds me of a Harry Lorayne, but on kids magic. And it is entertaining to watch also.

Roberto Giobbi has the wonderful ability to teach magic in written words…Take Card College for example.
I wasn't so sure how he would do on video until I saw this: http://www.penguinmagic.com/p/3961

Incredible. One of my favorite magic teachers of all time!

Daryl, Matthew Dowden and Bill Malone

Daryl is a great teacher with gentle jokes (less jarring than jay sankey) and he always has tones of extra information regarding history and little known uses, methods and subtleties.

Matthew Dowden has a clear explanation method and though he might not stand out, he's a great teacher with nice pacing and a generally candid appeal.

Bill Malone has a huge difference in presentation in his explanation and performance but he explains stuff very well with nice anecdotes in between.

I've personally derived great benefit from Daryl (fooler dooler series), Sankey (the very best of series), Malone (on the loose series), and Colombini (the essential series).

There are several who have been cited by others here who I do not own material from and thus their ommission from my mini list is no reflection on them.

Amongst those given very few citations I'd like to give a big thumbs up to Richard Sanders, not only for fibre optics (as cited by someone else) but also for his excellent 3 disc dvd series 'The Richard Sanders Show'. I learnt a lot off that set delivered in a crystal-clear & accessible fashion by Richard.

Like the list, I would remove sankey and replace him with Dan Tong.

I'll only tell about books. So far, No author I've read topped Roberto Giobbi from his Card College.

P!

Gee, Ado, I sure tried!!!

Sorry Harry! Ya can't please 'em all!

For cards, yes, Harry Lorayne! Daryl and Ammar are good ones too! For coins, Rubinstein, Roth... I like Mike Gallo too. I think your best teachers are going to be one-on-one. For example, I bet Harry Lorayne COULD teach me to Back Palm and do the Classic Pass, neither of which I can do (yet).

Doug

I realize that ya can't please 'em all - I was just wondering if he's read my stuff. Not important at all. Best - HL.

I have learned so much from harry lorayne and pop haydn and vinny and the rest of the card magic magicians and I think if you view the card magic forum there are many good magicians there who teach a lot and show you how it is suppose to be done!

I believe you did. I've read some your books, as well as many other books by other magicians. It is well informed that I deliberately chose not to write your name, no matter what other people think.

P!

Of course, Ado. I'll just keep on tryin'!!